Create school #70
Create school #70
Conversation
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)
codeforlife/tests/model_view_set.py line 645 at r1 (raw file):
def login_non_school_teacher( self, is_admin: t.Optional[bool] = None,
Having is_admin here doesn't really make sense if the teacher doesn't have a school. We can probably just remove it
codeforlife/tests/model_view_set.py line 652 at r1 (raw file):
Args: is_admin: Whether or not the teacher is an admin. Set to None if the teacher can be either or.
And therefore remove this
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
codeforlife/tests/model_view_set.py line 645 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Having
is_adminhere doesn't really make sense if the teacher doesn't have a school. We can probably just remove it
Done.
codeforlife/tests/model_view_set.py line 652 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
And therefore remove this
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is