fix: don't get secret key from env var

ocadotechnology · Feb 21, 2025 · 9b5a591 · 9b5a591
1 parent f322e55
commit 9b5a591
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/codeforlife/__init__.py b/codeforlife/__init__.py
@@ -54,7 +54,7 @@ def set_up_settings(service_base_dir: Path, service_name: str):
         from codeforlife.settings import *
 
         # Expose secret to django project.
-        MY_SECRET = secrets.MY_SECRET
+        SECRET_KEY = secrets.SECRET_KEY
         ```
 
     Args:
@@ -108,6 +108,9 @@ def set_up_settings(service_base_dir: Path, service_name: str):
                 secrets_file.write(secrets_file_comment)
 
         secrets = dotenv_values(secrets_path)
+        secrets.setdefault(
+            "SECRET_KEY", "XTgWqMlZCMI_E5BvCArkif9nrJIIhe_6Ic6Q_UcWJDk="
+        )
     else:
         # pylint: disable-next=import-outside-toplevel
         import boto3

diff --git a/codeforlife/settings/django.py b/codeforlife/settings/django.py
@@ -122,11 +122,6 @@ def get_databases():
     "django.middleware.clickjacking.XFrameOptionsMiddleware",
 ]
 
-# SECURITY WARNING: keep the secret key used in production secret!
-SECRET_KEY = os.getenv(
-    "SECRET_KEY", "XTgWqMlZCMI_E5BvCArkif9nrJIIhe_6Ic6Q_UcWJDk="
-)
-
 # Auth
 # https://docs.djangoproject.com/en/4.2/topics/auth/default/