Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: Kurono code changes in game and starter/hint code #1792

Merged

Conversation

cewei8483
Copy link
Contributor

@cewei8483 cewei8483 commented Jul 21, 2023

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

Copy link
Collaborator

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @cewei8483)


aimmo/worksheets.py line 41 at r1 (raw file):

#    Task 3: Investigate location
#       - Investigate what `print(avatar_state.location)` tells you and then
#         check if you can move to the next location.If you can't move to the

add a space ". If"

Copy link
Collaborator

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cewei8483)

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1792 (966496c) into master (a7574d4) will increase coverage by 21.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1792       +/-   ##
===========================================
+ Coverage   66.32%   88.20%   +21.88%     
===========================================
  Files         179       38      -141     
  Lines        3661     1060     -2601     
  Branches      255      109      -146     
===========================================
- Hits         2428      935     -1493     
+ Misses       1201      102     -1099     
+ Partials       32       23        -9     
Impacted Files Coverage Δ
aimmo-game-worker/simulation/utils.py 100.00% <100.00%> (ø)

... and 151 files with indirect coverage changes

@cewei8483 cewei8483 merged commit 4630e7d into master Jul 21, 2023
8 checks passed
@cewei8483 cewei8483 deleted the 1459-kurono-code-changes-in-game-and-starterhint-code branch July 21, 2023 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kurono code changes in game and starter/hint code
2 participants