Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Fix manifest commit hash comparison #11834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsaedtler
Copy link
Contributor

Description

Fixes the comparison for the manifest commit hash.

Motivation and Context

The intention here was to allow updates for builds that don't have distinct version numbers, e.g. on feature test branches. We never used this upstream but at Twitch we used it for our beta builds and I found the problem there.

How Has This Been Tested?

Twitch closed beta OBS builds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants