Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Obsidian Plugin Stats webapp #729

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ooker777
Copy link
Contributor

@ooker777 ooker777 commented Sep 3, 2024

Edited

Added

Checklist

Copy link
Contributor

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for doing this!

Comment on lines +15 to +17
## Tools in this category
- [[Obsidian Plugin Stats|Obsidian Plugin Stats]]
%% Add a bullet here and link to the plugins you'd like to categorize! %%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I just wanted to record my thoughts on why...

Looking at the other categories in this folder, you will see they mostly don't contain explicit links.

They all work via backlinks - see this, for example:
https://publish.obsidian.md/hub/02+-+Community+Expansions/02.04+Auxiliary+Tools+by+Category/iPadOS+Apps

The advantage of this is that if an auxiliary tool changes what platforms it supports, only one file needs to change - the note for the tool - rather than having to keep 2 lots of data synchronised.

However, the template for this category does contain a "Tools in this Category" heading - and a few of the existing files do contain it too.

So I am happy for this link to remain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isn't the template populated automatically? Because relying on backlink isn't reliable, as by default a new plugin will list all categories. For example, Docker isn't an iPadOS app, but it appears on the backlink of that category.

@claremacrae
Copy link
Contributor

@ooker777 - I see you have created your PR from your main branch.

You should always create a branch on forked repos, before committing changes that are to go in to a pull request.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

By not creating a branch and putting the PR in to the default branch (main, master or whatever), you run the risk that it will be very difficult to add later commits to your fork, or get new changes from the parent repo.

For example, these problems would happen if the PR was declined. It could also happen if the maintainer squashed the changes.

@claremacrae claremacrae merged commit 23f986b into obsidian-community:main Sep 3, 2024
2 checks passed
@ooker777
Copy link
Contributor Author

ooker777 commented Sep 4, 2024

Good tip. Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants