#23 Option to pass custom headers #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering this project as dead. |
|
Cool, just because someone doesn't want to merge you PR it's dead. Great logic. |
|
No activity on PRs for one year. Sorry if I looked agressive, this wasn't my intent. I was juste cleaning my open PRs. If you are interested in those PRs I can reopen them. I know that maintaining a project is hard ;) |
robertoronderosjr
suggested changes
Mar 2, 2017
| // | ||
| var headers = {}; | ||
| cli.header.forEach(function(header){ | ||
| var keyValue = header.split(':'); |
There was a problem hiding this comment.
Header Val might have ':' therefore the split will be wrong. Try:
var keyValue = header.split(/:/);
var key = keyValue.shift();
var value = keyValue.join(':');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23