Skip to content

support shorthand projection: {domain: "sphere"} #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: fil/iterable-projection-domain
Choose a base branch
from
Draft

support shorthand projection: {domain: "sphere"} #1154

wants to merge 1 commit into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Dec 5, 2022

As a complement to #1153 (suggested in #1148). Might come in handy, but I'm not sure we want too many special cases.

@Fil Fil added enhancement New feature or request question Further information is needed geo Maps and projections labels Dec 5, 2022
@Fil Fil requested a review from mbostock December 5, 2022 10:54
mbostock
mbostock requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than first looking at domain.type, we should check whether typeof domain === "string" and then treat it as a keyword, using maybeKeyword so that you get a nice error message if you typo "sphere".

@Fil Fil marked this pull request as draft December 6, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock requested changes

Assignees
No one assigned
Labels
enhancement New feature or request geo Maps and projections question Further information is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fil @mbostock