fix: add context to prevent notion from creating unwanted pages #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
drpebcak,
thedadams,
StrongMonkey,
iwilltry42,
ryanhopperlowe and
g-linville
|
Running into some dataset issues. Going to see if they're resolved with gptscript-ai/node-gptscript#102 |
drpebcak
requested changes
Nov 6, 2024
notion/package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "author": "", | |||
| "license": "Apache-2.0", | |||
| "dependencies": { | |||
| "@gptscript-ai/gptscript": "github:gptscript-ai/node-gptscript#b30db3cf4fe87b1ee09a20752baf2263b1e5c7be", | |||
| "@gptscript-ai/gptscript": "github:g-linville/node-gptscript#49125f86e4a0c2af02b85373fdf647699dfcd58b", | |||
There was a problem hiding this comment.
I'd rather just wait until grant's changes are merged rather than using his fork in the primary tool repo
There was a problem hiding this comment.
Totally, I'm just testing this in advance since datasets are currently broken against the latest version of gptscript
There was a problem hiding this comment.
OK -- the dataset changes have merged and I updated this dependency.
njhale
force-pushed
the
fix/notion-i251-plusplus
branch
10 times, most recently
from
ffb1d3b to
ec9eee5
Compare
thedadams
approved these changes
Nov 7, 2024
g-linville
approved these changes
Nov 7, 2024
Add context to the Notion tools to confirm with the user before creating new pages. This will prevent pages from being created when the user is actually attempting to update the content of an existing page. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
fix/notion-i251-plusplus
branch
from
ec9eee5 to
31eb6f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add context to the Notion tools to confirm with the user before creating new pages. This will prevent pages from being created when the user is actually attempting to update the content of an existing page.
This change also bumps node-gptscript to include the new dataset changes.
Addresses https://github.com/otto8-ai/otto8/issues/251