-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ratio_location.yaml #273
Conversation
ar-ibrahim
commented
Jul 20, 2023
•
edited
Loading
edited
- issue Create new 'ratio' DOS-DP pattern template #272
- Rough (very) draft of 'ratio' pattern, including proposed name of pattern.
- To discuss in monthly OBA meeting (July 21st 2023)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to change the name of the pattern, because it does not specify the location explicitly. The components attribute1 and attribute2 should specify and imply the location of the ratio-attribute defined here.
We can further improve the text later.
@rays22 This is the suggested change to the name of the pattern, |
Changed name of pattern, as suggested.
I have consulted @rays22 about the recurring QC warnings and as per my understanding this has been an outstanding issue that does not prevent merging the PR should the suggested changes be approved. |