Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v0.9.0 #92

Merged
merged 2 commits into from
Jun 8, 2024
Merged

release: v0.9.0 #92

merged 2 commits into from
Jun 8, 2024

Conversation

graphql-ws-client-releaser[bot]
Copy link
Contributor

@graphql-ws-client-releaser graphql-ws-client-releaser bot commented May 16, 2024

🤖 New release

  • graphql-ws-client: 0.8.2 -> 0.8.3 (✓ API compatible changes)
Changelog

v0.8.3 - 2024-06-08

New Features

  • send periodic pings for keep alives (#103)
  • impl debug for client (#101)
  • add keep-alive capability (#93)

Bug Fixes

  • swap no-logging feature for logging feature (#97)

Changes

  • Fix compilation error in actor mod (#96)
  • release-plz config tweaks (#95)
  • simplify keep alive implementation (#94)
  • pin release-plz version (#91)


This PR was generated with release-plz.

@graphql-ws-client-releaser graphql-ws-client-releaser bot force-pushed the release-plz-2024-05-16T20-56-50Z branch 3 times, most recently from 9cc609d to f69eda2 Compare May 23, 2024 10:54
@rhishikeshj
Copy link
Contributor

rhishikeshj commented May 23, 2024

@obmarg it's weird that the CI action which uses cargo build --all-features works but cargo build does not

▶ cargo build --all-features
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s

▶ cargo build
   Compiling graphql-ws-client v0.8.2 (/Users/rhishikeshj/workspace/juxt/artis/src/graphql-ws-client)
error[E0425]: cannot find value `keep_alive_duration` in this scope
   --> src/next/actor.rs:173:29
    |
173 | ...                   keep_alive_duration
    |                       ^^^^^^^^^^^^^^^^^^^
    |
help: you might have meant to use the available field
    |
173 |                             self.keep_alive_duration
    |                             +++++

For more information about this error, try `rustc --explain E0425`.
error: could not compile `graphql-ws-client` (lib) due to 1 previous error

@graphql-ws-client-releaser graphql-ws-client-releaser bot force-pushed the release-plz-2024-05-16T20-56-50Z branch from a9c87ef to 0f744be Compare May 23, 2024 12:08
@obmarg
Copy link
Owner

obmarg commented May 23, 2024

@rhishikeshj yeah, I think it's because the no-logger feature disables logging, so --all-features was (counterintuitively) removing code.

I want to rethink that, in retrospect it was not a good idea.

@obmarg obmarg reopened this May 23, 2024
@graphql-ws-client-releaser graphql-ws-client-releaser bot force-pushed the release-plz-2024-05-16T20-56-50Z branch from cbb0b16 to 14b487a Compare May 23, 2024 13:43
@obmarg obmarg marked this pull request as draft May 23, 2024 18:33
@graphql-ws-client-releaser graphql-ws-client-releaser bot force-pushed the release-plz-2024-05-16T20-56-50Z branch from bfe91e6 to 16cb857 Compare June 7, 2024 11:19
@obmarg obmarg marked this pull request as ready for review June 8, 2024 12:29
@graphql-ws-client-releaser graphql-ws-client-releaser bot force-pushed the release-plz-2024-05-16T20-56-50Z branch from 8c87587 to 7259683 Compare June 8, 2024 12:31
@obmarg obmarg changed the title chore: release v0.8.3 release: v0.9.0 Jun 8, 2024
@obmarg obmarg merged commit b30e2b8 into main Jun 8, 2024
2 checks passed
@obmarg obmarg deleted the release-plz-2024-05-16T20-56-50Z branch June 8, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants