fix: remove futures from ws_stream_wasm module #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obmarg
force-pushed
the
obmarg/push-qzollyxwkpvw
branch
from
807afd1 to
d4bd0fd
Compare
In #107 I removed futures in favour of futures-lite in various places. However, because ws_stream_wasm is not a default feature I didn't notice that I'd not removed futures from there as well. CI also did not catch this because futures was used for the tungstenite feature, which is often always on. This PR removes futures entirely, by implementing our own copy of StreamExt::send based on the futures impl, and then making sure there's no remaining uses of futures in the crate.
obmarg
force-pushed
the
obmarg/push-qzollyxwkpvw
branch
from
d4bd0fd to
8067e3c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #107 I removed futures in favour of futures-lite in various places. However, because ws_stream_wasm is not a default feature I didn't notice that I'd not removed futures from there as well.
CI also did not catch this because futures was used for the tungstenite feature, which is often always on.
This PR removes futures entirely, by implementing our own copy of StreamExt::send based on the futures impl, and then making sure there's no remaining uses of futures in the crate.