-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes the updating process bug related with #91 #99
base: master
Are you sure you want to change the base?
Conversation
Tarık Taha Uygun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@ttuygun you need to sign the CLA and rebase, otherwise this can't be merged. (I don't know if it will be merged though) |
Is there any way we can get this PR progressed at all? Even if it means closing this PR and getting another contributor (like myself) to raise the changes? It seems the author is not active on this project at all. |
Hi, |
Fixes #91
The default updating URL depends on https://objective-see.com/products.json but it's no longer up-to-date in contrast with github. For this reason, I changed the updating url as github using github's public API. I also changed objectForKey methods according to new URL.
Here's the working example. In this example, I'm on 1.1.0 and program says 1.1.1 is available.