Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the updating process bug related with #91 #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ttuygun
Copy link

@ttuygun ttuygun commented Oct 18, 2018

Fixes #91

The default updating URL depends on https://objective-see.com/products.json but it's no longer up-to-date in contrast with github. For this reason, I changed the updating url as github using github's public API. I also changed objectForKey methods according to new URL.

Here's the working example. In this example, I'm on 1.1.0 and program says 1.1.1 is available.

screen shot 2018-10-19 at 00 49 02

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Tarık Taha Uygun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jonathancross
Copy link

@ttuygun you need to sign the CLA and rebase, otherwise this can't be merged. (I don't know if it will be merged though)

@jamesalfei
Copy link

Is there any way we can get this PR progressed at all? Even if it means closing this PR and getting another contributor (like myself) to raise the changes? It seems the author is not active on this project at all.

@mdjunior
Copy link

mdjunior commented Feb 16, 2024

Hi,
Analyzing the history of the issues repository, I think that not using the Github API is intentional.
In other words, it is expected that there will be version control outside of Github so that the latest versions of Github will only be made available to users after some testing period here. By putting LuLu to read directly from Github, we would be exposing people who want a stable version to new features that may not have been well tested yet.

#402 (comment)

@ttuygun ttuygun reopened this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating process do not work
5 participants