Opt out of dark theme on macOS #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forces the light appearance on macos until a dark variant of the stylesheet/iconset is worked on.
mnamici
force-pushed
the
mac-disable-darkaqua-appearance
branch
from
ed8f31b to
67838bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some work to do to properly support the dark theme on macOS 10.15+, like preparing a dark variant of the stylesheet and icon set and setting up an auto-detection mechanism.
This PR temporarily disables it for builds using the
NSRequiresAquaSystemAppearancekey so that at least it can be used without forcing the user to switch to a light theme variant.See #175