Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled localStorage and sessionStorage #89

Closed
wants to merge 1 commit into from
Closed

Enabled localStorage and sessionStorage #89

wants to merge 1 commit into from

Conversation

manjeshpv
Copy link

Cordova/Ionic/Phonegap not support cookies directly, So added storage classes

@joaogranado
Copy link
Member

Hi @manjeshpv, thanks for your contribution. Actually, this is a duplicate of #35. We're thinking about a total rewrite of this module, in order to improve composability, allowing developers to use different persistence mechanisms. For now I would recommend to take a look at #19, which solves explains how to override TokenService.

@jonkoops
Copy link

jonkoops commented Jun 26, 2016

@manjeshpv I've opened up a pull request that implements sessionStorage and removes the dependency on cookies altogether. You might want to give that a look. It also takes care of serializing and deserializing data trough JSON.parse and JSON.stringify,

@joaogranado
Copy link
Member

I'll close this PR based on what I said on #95 and #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants