Fix/pisa25 472/id attribute removed #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #2388 +/- ##
==========================================
Coverage 16.06% 16.06%
Complexity 4207 4207
==========================================
Files 391 391
Lines 13491 13491
==========================================
Hits 2168 2168
Misses 11323 11323 ☔ View full report in Codecov by Sentry. |
jsconan
requested changes
Aug 29, 2023
jsconan
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
It works very well, a comment is added before entering the edit mode.
The comment is properly removed once the edition is finished, and it is not present in the saved data. Good job!
Note: since the code was modified since the last bundling, you may need to bundle it again before pushing the code to a testing env 😉
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Version
There are 0 BREAKING CHANGE, 0 feature, 7 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://oat-sa.atlassian.net/browse/PISA25-472
Description
This PR adds comments to generated code to warn author if he uses sourceDialog to edit code of the interaction
How to test
Can be validated on kitchen env
Create item with widget, i.e. img (block or inline). Check the source code - the widget code should be wrapped with warning comments
<!-- autogenerated code, do not edit -->widget code
<!-- end of autogenerated code -->when item is saved, saveItem should not contain these comments