-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking/tdr 9/handlebars 4 upgrade #1373
base: develop
Are you sure you want to change the base?
Changes from all commits
48909f2
cd1b1c5
3ea5a7b
d1228a2
dfdb4b8
2cba160
ce606e1
7e495ba
33285fa
ef8ebe9
6926212
039ec34
94af228
a1ac13b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm pretty sure this file is never even called by any of the PCIs I've tested. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed, I did not find any usage. However, some 3rd-party PCI providers could use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: The idea looks very good. However, we need to make sure that
taoQtiItem/portableLib/handlebars_4
is loaded in the first place. Without this, the runtime will declare a dependency on an inexistent package...See oat-sa/extension-tao-itemqti-pci#379 (comment)