-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker/sapphire: Include Envoy proxy #626
Conversation
77d1af8
to
3db1d25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please add envoy support to emerald-localnet.
3db1d25
to
a41da67
Compare
ed82904
to
8df5cd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried testing it locally with the Oasis CLI, but it seems a TLS connection is required. Do you think we could simply use a self-signed cert?
oasis net add localnet a41bd4bc75f31e68ceb1e8543f1a08ca54069b155f980bdf0316ec16ed194772 localhost:8544
oasis net status --network localnet
Error: failed to retrieve remote node's chain context: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: tls: first record does not look like a TLS handshake"
8df5cd9
to
10f704a
Compare
Added. The GRPC port now supports both TLS with self-signed certs and unsecured traffic as well.
|
10f704a
to
3679404
Compare
Oasis CLI is still not entirely satisfied ;)
|
Fixed, but it turns out that the oasis-cli doesn't allow self-signed certs
IMO this should be fixed this in the CLI so that it supports untrusted connection for localhost (or via a flag). |
3679404
to
fa7b464
Compare
fa7b464
to
08e8d1e
Compare
Removed TLS support as discused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with the fork of Oasis CLI using oasisprotocol/oasis-sdk#2013 and works. Good job!
Fixes: #423
Envoy proxy is now included which exposes the clients node
internal.sock
on port8544
(by default). Envoy is used because it also supports grpc-web, which might be useful/needed when testing any dapps.