runtime-sdk: Add support for secp256r1 #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/secp256r1
branch
from
fb3cde4
to
507a7fe
Compare
Codecov Report
@@ Coverage Diff @@
## main #1436 +/- ##
========================================
Coverage 57.54% 57.55%
========================================
Files 134 135 +1
Lines 9636 9741 +105
========================================
+ Hits 5545 5606 +61
- Misses 4049 4093 +44
Partials 42 42
|
kostko
force-pushed
the
kostko/feature/secp256r1
branch
from
507a7fe
to
8c9763d
Compare
peternose
approved these changes
Aug 8, 2023
| for byte in &[context, message] { | ||
| <Sha512_256 as Digest>::update(&mut digest, byte); | ||
| } | ||
| let sig = ecdsa::Signature::from_der(signature.0.as_ref()) |
There was a problem hiding this comment.
Suggested change
| let sig = ecdsa::Signature::from_der(signature.0.as_ref()) | |
| self.verify_digest(digest, signature) |
There was a problem hiding this comment.
Could remove some duplicate code, but not needed, to be inline with k1.
kostko
force-pushed
the
kostko/feature/secp256r1
branch
from
8c9763d
to
6fb425c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1417