oasis-test-runner: Enable sgx_loader in client node #5868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
requested review from
kostko,
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
reviewed
Sep 25, 2024
| @@ -61,6 +61,8 @@ func (client *Client) ModifyConfig() error { | |||
| if len(client.runtimes) > 0 { | |||
| client.Config.Mode = config.ModeClient | |||
| client.Config.Runtime.Provisioner = client.runtimeProvisioner | |||
| client.Config.Runtime.SGXLoader = client.net.cfg.RuntimeSGXLoaderBinary | |||
There was a problem hiding this comment.
Is it possible that net or cfg is nil?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5868 +/- ##
==========================================
+ Coverage 64.93% 65.07% +0.14%
==========================================
Files 622 624 +2
Lines 63492 63724 +232
==========================================
+ Hits 41229 41470 +241
+ Misses 17379 17369 -10
- Partials 4884 4885 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matevz
force-pushed
the
matevz/fix/enable-sgx-loader-test-runner
branch
from
40179db
to
f1a1e2f
Compare
kostko
approved these changes
Oct 8, 2024
|
Since we won't be running ROFLs on the client nodes on sapphire-localnet yet I think there is no need for this PR anymore. |
|
Still makes sense to do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by oasisprotocol/oasis-web3-gateway#625