Add derive symmetric key unit test for X25519-Deoxys-II MRAE scheme #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmzheng
requested review from
kostko,
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
reviewed
Jun 1, 2022
There was a problem hiding this comment.
Fix commit message, squash into a single commit as the second commit is just a fixup, add a changelog fragment.
runtime/Cargo.toml
Outdated
| @@ -56,6 +56,7 @@ oid-registry = "0.4.0" | |||
| rsa = "0.5.0" | |||
| base64-serde = "0.6.1" | |||
| lru = "0.7.5" | |||
| hex = "0.4" | |||
There was a problem hiding this comment.
This should be under dev-dependencies as it is only used in tests.
kostko
changed the title
xmzheng
force-pushed
the
xmzheng/unittest_derive_symmetric_key
branch
from
c916b87
to
6875fac
Compare
nhynes
approved these changes
Jun 26, 2022
kostko
reviewed
Jun 27, 2022
| @@ -67,6 +67,7 @@ features = ["full"] | |||
|
|
|||
| [dev-dependencies] | |||
| # For storage interoperability tests only. | |||
| hex = "0.4" | |||
There was a problem hiding this comment.
This should be moved below as the above comment applies to the jsonrpc dependency.
|
@xmzheng ping on addressing the remaining issues and merging this. |
added 3 commits
August 23, 2022 08:34
xmzheng
force-pushed
the
xmzheng/unittest_derive_symmetric_key
branch
from
6875fac
to
cd7b0fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add same test logic for derive_symmetric_key for golang, rust, which should be identical to those in oasis-sdk/client-sdk/web-ts