Merge pull request #5914 from oasisprotocol/peternose/trivial/limit-p…

…oly-gen-loop secret-sharing/src/churp/dealer: Limit loop for polynomial generation
oasisprotocol · Oct 21, 2024 · 3509d52 · 3509d52
2 parents 73eacc7 + 30aa3e2
commit 3509d52
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/.changelog/5914.trivial.md b/.changelog/5914.trivial.md
diff --git a/secret-sharing/src/churp/dealer.rs b/secret-sharing/src/churp/dealer.rs
@@ -138,7 +138,7 @@ where
         // should execute once with an extremely high probability,
         // so there is no need to optimize it by randomly selecting
         // only the problematic coefficients.
-        loop {
+        for _ in 0..5 {
             let bp = BivariatePolynomial::<G::Scalar>::random(deg_x, deg_y, rng);
 
             let i = deg_x as usize;
@@ -154,6 +154,8 @@ where
 
             return Ok(bp);
         }
+
+        Err(Error::PolynomialGenerationFailed.into())
     }
 }
 

diff --git a/secret-sharing/src/churp/errors.rs b/secret-sharing/src/churp/errors.rs
@@ -22,6 +22,8 @@ pub enum Error {
     MergingNotFinished,
     #[error("polynomial degree mismatch")]
     PolynomialDegreeMismatch,
+    #[error("polynomial generation failed")]
+    PolynomialGenerationFailed,
     #[error("shareholder encoding failed")]
     ShareholderEncodingFailed,
     #[error("shareholder proactivization already completed")]