Try to auto-detect token type used in runtime transactions #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/better-runtime-tx-token-detection
branch
from
1da61cb
to
ebe0ff5
Compare
Use tx.data to figure out if it's something special, or the default native token.
csillag
force-pushed
the
csillag/better-runtime-tx-token-detection
branch
from
ebe0ff5
to
a16157b
Compare
lubej
approved these changes
Feb 21, 2024
lukaw3d
reviewed
Feb 21, 2024
| @@ -752,7 +752,9 @@ export const useGetRuntimeEvents: typeof generated.useGetRuntimeEvents = ( | |||
| event.body.amount.Amount, | |||
| paraTimesConfig[runtime].decimals, | |||
| ), | |||
| Denomination: getTokensForScope({ network, layer: runtime })[0].ticker, // TODO find this out from event data | |||
| Denomination: | |||
| event.body?.Denomination ?? | |||
There was a problem hiding this comment.
This doesn't exist. event.body?.amount.Denomination exists.
But event.body.amount.Denomination === '' above means that it is empty
There was a problem hiding this comment.
I have seen both existing on different data, IIRC.
There was a problem hiding this comment.
Right, when this code is executed, it's always empty. Removed useless condition in #1285.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
tx.bodyto figure out if it's something special, or the default native token.