Merge pull request #1443 from oasisprotocol/csillag/hide-nan

Avoid showing "NaN%" in the charts when there is no prev data
oasisprotocol · Jun 5, 2024 · f9b0642 · f9b0642
2 parents 0ec1962 + c2b8fb8
commit f9b0642
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.changelog/1443.trivial.md b/.changelog/1443.trivial.md
@@ -0,0 +1 @@
+Avoid showing "NaN%" in the charts when there is no prev data
diff --git a/src/app/components/PercentageGain/index.tsx b/src/app/components/PercentageGain/index.tsx
@@ -13,6 +13,9 @@ interface PercentageGainProps {
  * Negative percentage shows red box with down arrow.
  */
 export const PercentageGain: FC<PercentageGainProps> = ({ earliestValue, latestValue }) => {
+  // If the previous data was zero, we can't divide with it, it would just get us infinity or Nan...
+  if (earliestValue === 0) return
+
   const ratio = (latestValue - earliestValue) / earliestValue
 
   return (