-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Move Localnet development to separate page #977
Conversation
✅ Deploy Preview for oasisprotocol-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b2afac7
to
639f05f
Compare
@@ -79,91 +79,9 @@ ParaTime. | |||
[Emerald Mainnet]: ./network.mdx | |||
[Emerald Testnet]: ./network.mdx | |||
|
|||
## Running a Private Oasis Network Locally | |||
#### For development and testing, you can run a local [instance][localnet] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### For development and testing, you can run a local [instance][localnet] | |
## For development and testing, you can run a local [instance][localnet] |
Probably 2 # too much
I think having the old header and card to the localnet could be also a good way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Yeah, ##
is more consistent with "Testnet" etc. Let me try the text for now. I tend to think that the card takes the reader away from the flow of the document.
2a0e8e7
to
80db33b
Compare
docs/dapp/tools/localnet.mdx
Outdated
After a while, running the `sapphire-localnet` will show you something like: | ||
|
||
``` | ||
sapphire-localnet 2024-05-28-git37b7166 (oasis-core: 24.0-gitfb49717, sapphire-paratime: 0.7.3-testnet, oasis-web3-gateway: 5.1.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think devs need duplicated info for Emerald.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a output with a newer docker version would be good.
In this regard some info to update the docker image, with docker pull ghcr.io/oasisprotocol/sapphire-localnet:latest
to get the latest version which includes ROFL, could be helpful for devs that used localnet already months ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some ideas.
84e30a8
to
aff2b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit, otherwise LGTM.
7f043fa
to
306c29d
Compare
306c29d
to
42a2136
Compare
Description
Close #959
Note. Configuring Docusaurus redirect is not possible from an URL with an anchor.
message: '"redirects[54].from[0]" (/dapp/emerald/writing-dapps-on-emerald#running-a-private-oasis-network-locally) is not a valid pathname. Pathname should start with slash and not contain any domain or query string.',
TODO
PREVIEW