Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd/network/status): Sort paratimes #313

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat(cmd/network/status): Sort paratimes #313

merged 1 commit into from
Oct 25, 2024

Conversation

amela
Copy link
Member

@amela amela commented Oct 22, 2024

No description provided.

@amela amela linked an issue Oct 22, 2024 that may be closed by this pull request
Sort ParaTimes in network status command #266
Closed
@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit fde8786
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6719edeff695e800086c8ee3

@amela amela marked this pull request as ready for review October 22, 2024 09:34
@amela amela requested review from matevz and kostko October 22, 2024 09:34
matevz
matevz reviewed Oct 22, 2024
View reviewed changes
cmd/network/status.go Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/sort-paratimes branch 3 times, most recently from 86f27b5 to 75264a6 Compare October 22, 2024 14:10
@amela amela requested a review from matevz October 22, 2024 14:14
@amela amela force-pushed the amela/sort-paratimes branch 2 times, most recently from 73e8ea3 to 4279b09 Compare October 23, 2024 12:00
@amela amela requested a review from matevz October 23, 2024 12:03
matevz
matevz reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can simply append the ParaTime ID to the name and you will get a deterministic order?

cmd/network/status.go Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/sort-paratimes branch 2 times, most recently from b37cad0 to e148cb1 Compare October 24, 2024 06:44
@amela amela requested a review from matevz October 24, 2024 06:46
@matevz
Copy link
Member

matevz commented Oct 25, 2024

Works as expected. Merging.

@matevz matevz merged commit 6329841 into master Oct 25, 2024
4 checks passed
@matevz matevz deleted the amela/sort-paratimes branch October 25, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevz matevz matevz approved these changes

@kostko kostko Awaiting requested review from kostko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort ParaTimes in network status command
2 participants
@amela @matevz