Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/paratime/denom): Add cmd denomination set, set-native and remove #242

Merged
merged 1 commit into from
May 29, 2024

Conversation

amela
Copy link
Member

@amela amela commented May 20, 2024

Fixes #241 and part of #209.

  • oasis paratime denom set <network> <paratime> <denomination> <number_of_decimals> --symbol <symbol> (if someone sets denomination to _ it does not allow them to change denom, if symbol is not specified defaulting to <denomination>)
  • oasis paratime denom set-native <network> <paratime> <denomination> <number_of_decimals>
  • oasis paratime denom remove <network> <paratime> <denomination>

@amela amela requested review from matevz and kostko May 20, 2024 08:52
@amela amela linked an issue May 20, 2024 that may be closed by this pull request
Copy link

netlify bot commented May 20, 2024

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 0b86b5e
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/66571dd82c61ce0007fdb854

@kostko kostko marked this pull request as ready for review May 20, 2024 09:03
@amela amela force-pushed the amela/feat/add-cmd-oasis-paratime-denom branch 6 times, most recently from 98eb3e9 to 233ecf7 Compare May 22, 2024 14:37
cmd/paratime/denom/add.go Outdated Show resolved Hide resolved
cmd/paratime/denom/denom.go Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
cmd/paratime/denom/add.go Outdated Show resolved Hide resolved
cmd/paratime/denom/add.go Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/feat/add-cmd-oasis-paratime-denom branch 4 times, most recently from dd111d3 to ccda414 Compare May 27, 2024 09:34
@amela amela requested a review from kostko May 27, 2024 09:40
@amela amela changed the title feat(cmd/paratime/denom): Add cmd denomination add feat(cmd/paratime/denom): Add cmd denomination set and set-native May 27, 2024
@amela amela force-pushed the amela/feat/add-cmd-oasis-paratime-denom branch from ccda414 to a9e51f9 Compare May 27, 2024 13:49
cmd/paratime/denomination/set-native.go Outdated Show resolved Hide resolved
cmd/paratime/denomination/set.go Outdated Show resolved Hide resolved
cmd/paratime/denomination/set.go Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/feat/add-cmd-oasis-paratime-denom branch from a9e51f9 to 10f9e83 Compare May 27, 2024 14:34
@amela amela requested a review from kostko May 27, 2024 14:40
@amela amela force-pushed the amela/feat/add-cmd-oasis-paratime-denom branch from 10f9e83 to 8db938b Compare May 28, 2024 09:42
@amela amela changed the title feat(cmd/paratime/denom): Add cmd denomination set and set-native feat(cmd/paratime/denom): Add cmd denomination set, set-native and remove May 28, 2024
@amela amela force-pushed the amela/feat/add-cmd-oasis-paratime-denom branch from 8db938b to 4dc06e2 Compare May 29, 2024 06:51
cmd/paratime/denomination/remove.go Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/feat/add-cmd-oasis-paratime-denom branch 2 times, most recently from cd62956 to a4a32f8 Compare May 29, 2024 10:01
@amela amela requested a review from kostko May 29, 2024 10:15
cmd/paratime/denomination/set-native.go Outdated Show resolved Hide resolved
cmd/paratime/denomination/set.go Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/feat/add-cmd-oasis-paratime-denom branch from a4a32f8 to 0b86b5e Compare May 29, 2024 12:21
@amela amela merged commit 45afc60 into master May 29, 2024
4 checks passed
@amela amela deleted the amela/feat/add-cmd-oasis-paratime-denom branch May 29, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new subcmds denom set and denom set-native and denom remove
3 participants