Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context: check required constructor parameters aren't null #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Context: check required constructor parameters aren't null #11

wants to merge 2 commits into from

Conversation

jnidzwetzki
Copy link

This PR introduces a null parameter check in the constructor. Especially when the ContextBuilder is used, it easy to forget required parameters (e.g., application) and the resulting Exception does not point out the missing parameter. With this patch, a customized NullPointerException is thrown.

== Old ==

Exception in thread "main" java.lang.NullPointerException
	at com.oanda.v20.Context.<init>(Context.java:93)
	at com.oanda.v20.ContextBuilder.build(ContextBuilder.java:100)

== New ==

Exception in thread "main" java.lang.NullPointerException : application can not be null
	at com.oanda.v20.Context.<init>(Context.java:92)
	at com.oanda.v20.ContextBuilder.build(ContextBuilder.java:100)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant