Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ceph][luks] Fix ceph cephvolumescan for cephadm #1230

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented May 13, 2024

For cephadm the containers are named ceph--osd... while ceph-ansible still uses the ceph-osd-...

Other issue is that OSDs can have multiple volumes in them so filtering just for the first one is wrong and we need to check each volume for the encryption.

Resolves: rhbz#2264543
Fixes: https://issues.redhat.com/browse/RHEL-25838

Orig PR: #1180

TODO:

  • fix the bug
  • remove added debug msgs from tests

For cephadm the containers are named ceph-<hash>-osd... while
ceph-ansible still uses the ceph-osd-...

Other issue is that OSDs can have multiple volumes in them so filtering
just for the first one is wrong and we need to check each volume for
the encryption.

Resolves: rhbz#2264543
Fixes: https://issues.redhat.com/browse/RHEL-25838
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use /packit test oamg/leapp#42
Note that first time contributors cannot run tests automatically - they will be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89 pirat89 added the bug Something isn't working label May 13, 2024
@pirat89 pirat89 added this to the 8.10/9.5 milestone May 13, 2024
@pirat89
Copy link
Member Author

pirat89 commented May 13, 2024

@xbezdick seems the code is broken, as for the lvm scan test we get:

{'0': [{'devices': ['/dev/sda'],                                     
        'lv_name': 'osd-block-c5215ba7-517b-45c7-88df-37a03eeaa0e9', 
        'lv_uuid': 'Tyc0TH-RDxr-ebAF-9mWF-Kh5R-YnvJ-cEcGVn',         
        'tags': {'ceph.encrypted': '1'},                             
        'type': 'block',                                             
        'vg_name': 'ceph-a696c40d-6b1d-448d-a40e-fadca22b64bc'}],    
 '8': [{'devices': ['/dev/nvme0n1'],                                 
        'lv_name': 'osd-db-b04857a0-a2a2-40c3-a490-cbe1f892a76c',    
        'lv_uuid': 'zcvGix-drzz-JwzP-6ktU-Od6W-N5jL-kxRFa3',         
        'tags': {'ceph.encrypted': '1'},                             
        'type': 'db',                                                
        'vg_name': 'ceph-b78309b3-bd80-4399-87a3-ac647b216b63'},     
       {'devices': ['/dev/sdb'],                                     
        'lv_name': 'osd-block-477c303f-5eaf-4be8-b5cc-f6073eb345bf', 
        'lv_uuid': 'Mz1dep-D715-Wxh1-zUuS-0cOA-mKXE-UxaEM3',         
        'tags': {'ceph.encrypted': '1'},                             
        'type': 'block',                                             
        'vg_name': 'ceph-e3e0345b-8be1-40a7-955a-378ba967f954'}]}    

see the type db instead of block

@xbezdick
Copy link

Reopened - #1255

@pirat89 pirat89 removed this from the 8.10/9.5 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants