Skip to content

Commit

Permalink
firewalldcheckallowzonedrifting: Fix the remediation cmd
Browse files Browse the repository at this point in the history 
The remediation cmd was incorrect as the cmd is written as string
instead of list, the fix:
  ['cmd param param'] -> ['cmd', 'paramm', 'param']

JIRA: OAMG-7694
  • Loading branch information
@pirat89 @mmacura311
pirat89 authored and mmacura311 committed Sep 30, 2022
1 parent b4c3de4 commit 279ebc9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion repos/system_upgrade/el8toel9/actors/firewalldcheckallowzonedrifting/actor.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ def process(self):
title='Changes in firewalld related to Zone Drifting'),
reporting.Remediation(
hint='Set AllowZoneDrifting=no in /etc/firewalld/firewalld.conf',
commands=[['sed -i "s/^AllowZoneDrifting=.*/AllowZoneDrifting=no/" '
commands=[['sed', '-i', 's/^AllowZoneDrifting=.*/AllowZoneDrifting=no/',
'/etc/firewalld/firewalld.conf']]),
])

1 comment on commit 279ebc9

@packit-as-a-service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your git-forge project github.com/oamg/leapp-repository has permissions to build in @oamg/leapp Copr project configured in Packit. However, we migrated to the solution where you can configure the allowed git-forge projects in Copr yourself and will remove the configuration in Packit for the allowed projects soon. Therefore, please, add this git-forge project github.com/oamg/leapp-repository to Packit allowed forge projectsin the Copr project settings.

Please sign in to comment.