feat: GNOME 48 support #343
Open
+1,087
−986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adjust the rollup settings to use version 16
- give them a more descriptive name - implement the suggestion for gnome 48, to use the newer orientation property is St.Widget, and prefer that, if it is available
this now correctly supports gnome 48, as the way to do that changed
Totto16
force-pushed
the
gnome_48_support
branch
from
477ec3b to
cf55c65
Compare
this is needed, as the tests can't import "Shell". But the test import db.ts > compatibility.ts > Shell, so we split the compatibility into two layers, to make the tests work again
- use Meta.Selection, instead of Selection,
Totto16
force-pushed
the
gnome_48_support
branch
from
cfc22b8 to
3a7d7ab
Compare
… extension.js this was done incorrectly previously, it didn't lead to any issues, but it was only a matter of time until that happens, which it did see https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell for more details
… files - this is due to the fact. that some resources, like Shell can't be imported in the preferences - fix all imports of those compatibility functions
Totto16
force-pushed
the
gnome_48_support
branch
from
3a7d7ab to
ffbbeb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support GNOME 48
uses guideline for migration from here
fixes #341
TODOs
I have tested this under gnome 48 on fedora 42 (not yet released) and gnome 47 on Ubuntu 24.10. It works flwalessly on both versions.
Checklist