Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arduino language support #1173

Closed
wants to merge 2 commits into from
Closed

Add arduino language support #1173

wants to merge 2 commits into from

Conversation

spenserblack
Copy link
Collaborator

Resolves #1171

cc @Sh4rk-Byte

@spenserblack spenserblack requested a review from o2sh as a code owner September 18, 2023 17:25
@spenserblack spenserblack mentioned this pull request Sep 18, 2023
Closed
1 task
spenserblack
spenserblack commented Sep 18, 2023
View reviewed changes
Copy link
Collaborator Author

@spenserblack spenserblack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm the author of this PR, I can't mark it as "changes requested". That's what I get for trying to help out 🤷 😆

Anyway, the ASCII art is too wide at 50 characters. We max out at 40.

languages.yaml Outdated
{0} -+++++++++++++++
colors:
ansi:
- turquoise
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- turquoise
- cyan

Turqoise isn't an ANSI color. Cyan is probably the closest.

@Sh4rk-Byte
Update languages.yaml
0a0b07b 
Made the ASCII smaller at only 40 characters wide + fixed the color.
spenserblack
spenserblack commented Sep 19, 2023
View reviewed changes
languages.yaml
{0} xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
{0} xxxxxxxxxxxxxxxxxxxxxxxxxxxx
{0} xxxxxxxxxxxxxxxxxxxxxxxx
{0} xxxxxxxxxxxxxxxxx
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still too wide due to trailing spaces 😆

https://github.com/o2sh/onefetch/actions/runs/6234189722/job/16922064863?pr=1173#step:5:575

@spenserblack
Copy link
Collaborator Author

@Sh4rk-Byte Sorry, I tried to be beginner-friendly by opening this PR for you, but it's kind of more trouble than it's worth on my side. I can't leave proper reviews, I wasn't able to mark this PR as "maintainers can modify this PR," and I've discovered that this PR is bypassing some security protections 😨

So are you OK with opening your own PR? I'm going to close this one to be safe. This has been a learning experience for me, too 😅

Feel free to ask me for help. I'd hate for your hard working making the ASCII art to be wasted 🙂

@Sh4rk-Byte Sh4rk-Byte deleted the Sh4rk-Byte-arduino-lang-support branch September 19, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o2sh o2sh Awaiting requested review from o2sh o2sh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arduino language support request
2 participants
@spenserblack @Sh4rk-Byte