Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coordinate Reference System #110

Merged
merged 6 commits into from
Jan 5, 2021
Merged

Coordinate Reference System #110

merged 6 commits into from
Jan 5, 2021

Conversation

SbastianGarzon
Copy link
Collaborator

@SbastianGarzon SbastianGarzon commented Jan 4, 2021 •
edited
Loading

Fixes #109

  • CRS output correspond to the transformation into WGS84.
  • Tests include CRS assessment

Also closes #103, #104 and #105

@SbastianGarzon SbastianGarzon requested a review from nuest January 4, 2021 17:08
nuest
nuest requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments, but nothing really critical.

I created a couple of issues/comments while thinking about the changes, for later: #111 #112 #80 (comment)

geoextent/lib/extent.py Outdated Show resolved Hide resolved
geoextent/lib/extent.py Outdated Show resolved Hide resolved
geoextent/lib/extent.py Outdated Show resolved Hide resolved
geoextent/lib/extent.py Outdated Show resolved Hide resolved
geoextent/lib/handleCSV.py Show resolved Hide resolved
geoextent/lib/handleVector.py Outdated Show resolved Hide resolved
geoextent/lib/handleVector.py Outdated Show resolved Hide resolved
geoextent/lib/handleVector.py Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
nuest
nuest requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final small change: please document the origin of the test file ifgi_denkpause.xx.

Good job addressing all the other comments 🚀 ❗

@nuest nuest merged commit 34f3b2a into o2r-project:master Jan 5, 2021
@SbastianGarzon SbastianGarzon mentioned this pull request Jan 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuest nuest nuest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output CRS Add temporal extent support for KML
2 participants
@SbastianGarzon @nuest