Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/riscv32i: split interpret_instruction in subroutines #2748

Open
wants to merge 1 commit into
base: dw/interpreter-constraint-witness-env
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

Leaving the implementation details for @svv232

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (692acab) to head (9c481e9).

Files with missing lines Patch % Lines
o1vm/src/interpreters/riscv32i/interpreter.rs 0.00% 20 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##           dw/interpreter-constraint-witness-env    #2748      +/-   ##
=========================================================================
- Coverage                                  72.11%   72.08%   -0.03%     
=========================================================================
  Files                                        255      255              
  Lines                                      59072    59090      +18     
=========================================================================
- Hits                                       42598    42595       -3     
- Misses                                     16474    16495      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant