Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/riscv32i: implement constraints, witness and interpreter env #2747

Open
wants to merge 3 commits into
base: dw/o1vm-riscv32i-instruction-set
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

Mostly copying from MIPS for now.

@dannywillems dannywillems force-pushed the dw/interpreter-constraint-witness-env branch from e8e1124 to 692acab Compare November 4, 2024 15:19
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1134 lines in your changes missing coverage. Please review.

Project coverage is 72.11%. Comparing base (536cbcb) to head (692acab).

Files with missing lines Patch % Lines
o1vm/src/interpreters/riscv32i/witness.rs 0.00% 519 Missing ⚠️
o1vm/src/interpreters/riscv32i/constraints.rs 0.00% 344 Missing ⚠️
o1vm/src/interpreters/riscv32i/interpreter.rs 0.00% 271 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           dw/o1vm-riscv32i-instruction-set    #2747      +/-   ##
====================================================================
- Coverage                             73.53%   72.11%   -1.43%     
====================================================================
  Files                                   253      255       +2     
  Lines                                 57938    59072    +1134     
====================================================================
- Hits                                  42604    42598       -6     
- Misses                                15334    16474    +1140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant