Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/riscv32i: introduce instruction set #2746

Open
wants to merge 12 commits into
base: dw/o1vm-riscv32i-introduce-scratch-size-column
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

No description provided.

@dannywillems dannywillems marked this pull request as draft November 4, 2024 10:54
@dannywillems dannywillems marked this pull request as ready for review November 4, 2024 12:56
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 10.94891% with 122 lines in your changes missing coverage. Please review.

Project coverage is 73.53%. Comparing base (89d9af9) to head (536cbcb).

Files with missing lines Patch % Lines
o1vm/src/interpreters/riscv32i/interpreter.rs 14.15% 91 Missing ⚠️
o1vm/src/interpreters/riscv32i/column.rs 0.00% 31 Missing ⚠️
Additional details and impacted files
@@                                Coverage Diff                                 @@
##           dw/o1vm-riscv32i-introduce-scratch-size-column    #2746      +/-   ##
==================================================================================
- Coverage                                           73.67%   73.53%   -0.14%     
==================================================================================
  Files                                                 252      253       +1     
  Lines                                               57801    57938     +137     
==================================================================================
+ Hits                                                42583    42604      +21     
- Misses                                              15218    15334     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants