MSM: add rangecheck4 and rangecheck15 lookups in constraints #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
changed the title
querolita
approved these changes
Mar 14, 2024
| @@ -15,13 +16,17 @@ pub struct Env<Fp> { | |||
| /// folding for instance. | |||
| pub constraints: Vec<(usize, Expr<ConstantExpr<Fp>, Column>)>, | |||
| pub constrain_index: usize, | |||
| pub rangecheck4_lookups: Vec<Lookup<E<Fp>>>, | |||
There was a problem hiding this comment.
I wonder if it is really a good idea to have the lookups split into different variable names. Looks more general to have just a single lookups vector, and then all of them get pushed into it.
There was a problem hiding this comment.
Yeah, probably we should think of a way to generalize them to just have one. And then if you really need the distinction of different tables, think of a different way to split them but "inside" the lookup type/vector/struct/whatever. Maybe for a follow up.
There was a problem hiding this comment.
Yes, agreed. This is ugly atm, and we must generalize. Let's do it quickly after everything works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #1966