Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSM: use constant size witness and rename old witness in ProofInputs #1869

Merged
merged 1 commit into from
Feb 29, 2024
Merged

MSM: use constant size witness and rename old witness in ProofInputs #1869

merged 1 commit into from
Feb 29, 2024

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Feb 29, 2024 •
edited
Loading

@dannywillems dannywillems mentioned this pull request Feb 29, 2024
Merged
Base automatically changed from dw/serializer-main-file to master February 29, 2024 13:16
@dannywillems dannywillems force-pushed the dw/serializer-unify-witness-proof-inputs branch from 56cb625 to 6d330b8 Compare February 29, 2024 14:37
@dannywillems dannywillems changed the base branch from master to dw/msm-witness-lt-iterator February 29, 2024 14:37
@dannywillems dannywillems force-pushed the dw/serializer-unify-witness-proof-inputs branch from 6d330b8 to 988918e Compare February 29, 2024 15:21
Base automatically changed from dw/msm-witness-lt-iterator to master February 29, 2024 15:52
@dannywillems dannywillems force-pushed the dw/serializer-unify-witness-proof-inputs branch from 988918e to 5106f87 Compare February 29, 2024 15:53
dannywillems
dannywillems commented Feb 29, 2024
View reviewed changes
msm/src/verifier.rs
@@ -50,25 +51,24 @@ pub fn verify<
let omega = domain.d1.group_gen;
let zeta_omega = zeta * omega;

let mut es: Vec<_> = zeta_evaluations
let mut es: Vec<Vec<Vec<G::ScalarField>>> = zeta_evaluations
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will change the type later. But it does imply changes outside the scope of this PR

@dannywillems dannywillems changed the title WIP - MSM: use constant size witness and rename old witness in ProofI… MSM: use constant size witness and rename old witness in ProofInputs Feb 29, 2024
volhovm
volhovm approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@volhovm volhovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this stuff is very directly conflicting with my PR :( Would be nice to avoid code duplication in the future.

msm/src/lib.rs Show resolved Hide resolved
querolita
querolita approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@querolita querolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for minor rename, looks very nice!

msm/src/main.rs Show resolved Hide resolved
msm/src/serialization/main.rs Show resolved Hide resolved
@dannywillems dannywillems mentioned this pull request Feb 29, 2024
Closed
@dannywillems dannywillems merged commit c8816ab into master Feb 29, 2024
4 checks passed
@dannywillems dannywillems deleted the dw/serializer-unify-witness-proof-inputs branch February 29, 2024 20:24
@dannywillems dannywillems self-assigned this Mar 7, 2024
@dannywillems dannywillems added the enhancement New feature or request label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@querolita querolita querolita approved these changes

@volhovm volhovm volhovm approved these changes

Assignees

@dannywillems dannywillems

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannywillems @volhovm @querolita