Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inverse_round and alternate definition of is_round() #1736

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

querolita
Copy link
Member

Partially addresses #1709 and related to the old #1667 that was closed to address each issue independently.

After Matthew's input here, we now know that MIPS and Keccak columns won't intermingle because we will be having two different instances (one for each). This means that we don't need to consider the case that a row is not a sponge nor a round, but an instruction. Consequently, we can be fine with a negated definition of is_round() as not(is_sponge()), reducing by one not only the columns (because we no longer need inverse_round to check that the round number is nonzero) but it also removes one constraint. It removes the dummy entry of the round constants table, as the 0 entry now corresponds to the first keccak round (as it used to be before #1596)

This simplifies the code and reduces some code duplications in the main.

Base automatically changed from mips/keccak/proof-witness to master January 23, 2024 13:18
@querolita querolita merged commit 371871a into master Jan 23, 2024
8 checks passed
@querolita querolita deleted the zkvm/keccak/24rounds branch January 23, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants