Propagate witness of each Keccak step #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let keccak_reset_pre_folding_witness = | ||
| |keccak_columns: &mut KeccakColumns<Vec<Fp256<FrParameters>>>| { | ||
| // Resize without deallocating |
There was a problem hiding this comment.
It is not resizing I think.
| inverse_round: Vec::with_capacity(domain_size), | ||
| flags_bytes: std::array::from_fn(|_| Vec::with_capacity(domain_size)), | ||
| pad_suffix: std::array::from_fn(|_| Vec::with_capacity(domain_size)), | ||
| round_constants: std::array::from_fn(|_| Vec::with_capacity(domain_size)), |
There was a problem hiding this comment.
I think the round constants are always the same no?
There was a problem hiding this comment.
Yes, they are fixed. It is a pity we use witness columns to store them. In Kimchi they were passed on as gate coefficients, but with folding we cannot really do that without making instances differ from each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1695 and #1696.
This PR finalizes the (pre-folding) Keccak integration with the zkVM and Syscalls.
Related issues that would clean-up this code:
KeccakColumnsto reduce clones beforeinto_iter()insideproof.rs#1718Pending tasks: