Merge pull request #2721 from o1-labs/marc/fix-cons-sel

o1vm/pickles: fix selectors constraints
o1-labs · Oct 18, 2024 · 8c9ceb3 · 8c9ceb3
2 parents 0dab255 + ae58bc5
commit 8c9ceb3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/o1vm/src/interpreters/mips/constraints.rs b/o1vm/src/interpreters/mips/constraints.rs
@@ -12,7 +12,7 @@ use crate::{
     lookups::{Lookup, LookupTableIDs},
     E,
 };
-use ark_ff::{Field, One, Zero};
+use ark_ff::{Field, One};
 use kimchi::circuits::{
     expr::{ConstantTerm::Literal, Expr, ExprInner, Operations, Variable},
     gate::CurrOrNext,
@@ -632,9 +632,9 @@ impl<Fp: Field> Env<Fp> {
                 (var.clone() - one.clone()) * var.clone()
             })
             .collect();
-        let enforce_one_activation = (0..N_MIPS_SEL_COLS).fold(E::<Fp>::zero(), |res, i| {
+        let enforce_one_activation = (0..N_MIPS_SEL_COLS).fold(E::<Fp>::one(), |res, i| {
             let var = self.variable(MIPSColumn::Selector(i));
-            res + var.clone()
+            res - var.clone()
         });
 
         enforce_bool.push(enforce_one_activation);