Skip to content

Commit

Permalink
o1vm: remove old FIXME
Browse files Browse the repository at this point in the history
  • Loading branch information
dannywillems committed Nov 1, 2024
1 parent 67fa659 commit 2f78e37
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
1 change: 0 additions & 1 deletion o1vm/src/pickles/prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ where
// We compute the polynomial t(X) by dividing the constraints polynomial
// by the vanishing polynomial, i.e. Z_H(X).
let (quotient, rem) = expr_evaluation_interpolated
// FIXME: Should this be d8?
.divide_by_vanishing_poly(domain.d1)
.unwrap_or_else(fail_final_q_division);
// As the constraints must be verified on H, the rest of the division
Expand Down
3 changes: 1 addition & 2 deletions o1vm/src/pickles/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ fn test_small_circuit() {
.unwrap();

let instant_before_verification = Instant::now();
let verif =
verify::<Pallas, BaseSponge, ScalarSponge>(domain, &srs, &vec![expr.clone()], &proof);
let verif = verify::<Pallas, BaseSponge, ScalarSponge>(domain, &srs, &[expr.clone()], &proof);
let instant_after_verification = Instant::now();
debug!(
"Verification took: {} ms",
Expand Down
5 changes: 2 additions & 3 deletions o1vm/src/pickles/verifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ pub fn verify<
>(
domain: EvaluationDomains<G::ScalarField>,
srs: &<OpeningProof<G> as OpenProof<G>>::SRS,
//FIXME: change vec to array
constraints: &Vec<E<G::ScalarField>>,
constraints: &[E<G::ScalarField>],
proof: &Proof<G>,
) -> bool
where
Expand Down Expand Up @@ -177,7 +176,7 @@ where
};

let combined_expr =
Expr::combine_constraints(0..(constraints.len() as u32), constraints.clone());
Expr::combine_constraints(0..(constraints.len() as u32), constraints.to_vec());

let numerator_zeta = PolishToken::evaluate(
combined_expr.to_polish().as_slice(),
Expand Down

0 comments on commit 2f78e37

Please sign in to comment.