Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic arrays in o1js #1848

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Dynamic arrays in o1js #1848

wants to merge 28 commits into from
+995 −3

Conversation

querolita
Copy link
Member

@querolita querolita commented Oct 2, 2024 •
edited
Loading

Addressing #1086, based on #633

Making this public as WIP to receive early feedback

@querolita querolita changed the title DynamicArrays in o1js ArrayLists in o1js Oct 7, 2024
@mitschabaude
Copy link
Collaborator

mitschabaude commented Oct 11, 2024 •
edited
Loading

@querolita @Trivo25 maybe of interest: I created quite polished general-purpose types for both static and dynamic arrays in this PR: zksecurity/mina-credentials#25

They made it pretty easy to implement dynamic-length sha256.

I think they could serve as a starting point for arrays in o1js that are (even) better designed than the D. Gretzke repo!

@querolita querolita changed the title ArrayLists in o1js Dynamic arrays in o1js Oct 17, 2024
@querolita querolita marked this pull request as ready for review October 17, 2024 17:51
@querolita
Merge branch 'main' into feature/dynamic-arrays
4fe6f43
@querolita
revert subproject commit of bindings and mina
da4990c
@querolita
revert function name changes after merge collision toBigInt/toBigint …
e813b7c 
…and null/synthesize
@querolita
remove runtime tables from this branch, and revert package.json modif…
77a80db 
…ications
@querolita
revert changes to package-lock.json
354bb0e
@querolita
remove changes to esbuild
2cf25fa
@querolita
revert more changes to package-lock.json caused by esbuild
c8e21f1
@querolita
update changelog
fcd6ebf
@querolita
use zkprogram to be able to test prover functions in dynamic arrays
57dd9cb
@querolita
comment parts of the unit test
4fb72f0
@querolita
enable mapping test
677ee2c
@querolita
include set and get test
5fb42f8
@querolita
fix popping multiple elements
aceb442
@querolita
increment and decrement length
49138bf
@querolita
move functions around
fd6007e
@querolita
simplify add in map test
3af547b
@querolita
remove unused functions
01cb38b
@querolita
create assert none in Option
a40cb0a
@querolita
shift left and test
37a72b2
@querolita
allow shifting left length positions
8536114
@querolita
copy, slice, and fix shift left
45ea600
@querolita
added shiftRight function
a06a607
@querolita
added concat functionality
0b54106
@querolita querolita changed the base branch from v1 to main November 7, 2024 08:41
@querolita querolita requested review from a team as code owners November 7, 2024 08:41
@querolita
Copy link
Member Author

querolita commented Nov 12, 2024 •
edited
Loading

TODO

  • Include complexity of each function
  • Improve efficiency making further use of cached masked positions
  • Randomized tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shigoto-dev19 Shigoto-dev19 Awaiting requested review from Shigoto-dev19 Shigoto-dev19 is a code owner automatically assigned from o1-labs/exploration-team

@Geometer1729 Geometer1729 Awaiting requested review from Geometer1729 Geometer1729 is a code owner automatically assigned from o1-labs/future-zkapps

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@querolita @mitschabaude