Add test for attempting to get tasks without a valid access token #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangdzh
requested changes
May 12, 2024
| def test_get_tasks_without_token(): | ||
| response = TEST_CLIENT.get(TASKS) | ||
| assert response.status_code == HTTPStatus.BAD_REQUEST | ||
| assert TOKEN_ERROR_MESSAGE in response.get_json()['error'] |
There was a problem hiding this comment.
This assumes both comments and tasks components will consistently use the same error message
There was a problem hiding this comment.
Looks good to me, refer to @zhangdzh's review to improve how the comments and tasks errors are handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new test to ensure that the /api/tasks endpoint correctly handles requests that are missing the required access token. The test checks that the response status code is
400 BAD REQUESTand that the error message explicitly states that an access token is required.Also resolved linting errors within the following files:
comments.pytasks.pymain.pytest_main.pyRelevant Issue
No relevant issues, just a general testing improvement.
Tests
The new test, along with previously existing ones, was run locally and passed successfully.