add css/scss modules support, back #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lquixada
reviewed
Apr 8, 2024
| @@ -14,7 +14,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node-version: [12.x, 14.x, 16.x] | |||
| node-version: [18.x, 20.x] | |||
There was a problem hiding this comment.
I added support for 20. That includes support for 18. So why not 🤷?
lquixada
reviewed
Apr 8, 2024
.mise.toml
Outdated
| yarn = '1.19.0' | ||
|
|
||
| [env] | ||
| RTX_FETCH_REMOTE_VERSIONS_TIMEOUT="300 s" |
There was a problem hiding this comment.
is there a mise alternative for this variable?
There was a problem hiding this comment.
I think so, but it's not documented very well. I updated -- thanks for pointing that out.
(This timeout is needed because node.org can have excessively slow download times. Not sure if that's fixed at this point.)
lquixada
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*.module.scss