Read templates from and to directories #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this will also be helpful for those with large kubernetes configurations (with multiple resources like configmaps that can span a lot of lines, but are infrequently changed). |
|
PTAL @yunzhu-li @balser |
|
Closing for now, will review design another time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27.
Closes #29.
Will need to update the changelog.
This change requires developers to put their templates into a folder (default
.kube/). As a result, they can create a file for each resource (likedeployment.yml,service.yml) if they find one file become too large.The other change this brings is that instead of rendering the templates to
/tmp, this writes them to a folder in the workspace/working directory (default.kube-out/). The goal is to be able to upload them to GCS or somewhere.I'm not sure if the default should remain as
/tmp.