Skip to content

Max/general abstraction updates #5560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 93 commits into
base: develop
Choose a base branch
from
Open

Max/general abstraction updates #5560

wants to merge 93 commits into from

Conversation

mfahampshire
Copy link
Contributor

@mfahampshire mfahampshire commented Mar 4, 2025 •
edited
Loading

This PR adds:

  • proper disconnect logic to the NymProxyServer via a channel
  • standalone CLI + crate for EchoServer
  • general code cleanup / organisation with the utils exposed by the TcpProxy SDK module

TODO before ready:

  • export utils.rs
  • import utils across used crates
  • update example
  • echo server readme
  • add additional check for reconstructedMessage format in ProxyServer
  • check TODOs

This change is Reviewable

@mfahampshire mfahampshire requested a review from octol as a code owner March 4, 2025 22:13
@mfahampshire mfahampshire force-pushed the max/general-abstraction-updates branch from 2686ac8 to 3066a44 Compare March 4, 2025 22:48
@vercel Vercel
Copy link

vercel bot commented Mar 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nym-explorer-v2 ❌ Failed (Inspect) Apr 27, 2025 5:23pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2025 5:23pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2025 5:23pm

@mfahampshire mfahampshire marked this pull request as draft March 4, 2025 22:59
@mfahampshire mfahampshire mentioned this pull request Mar 5, 2025
Closed
12 tasks
@octol octol removed their request for review March 11, 2025 08:37
@mfahampshire mfahampshire marked this pull request as ready for review April 2, 2025 15:46
@mfahampshire mfahampshire force-pushed the max/general-abstraction-updates branch from 8d61cc8 to 3e6bdde Compare April 2, 2025 15:51
@mfahampshire mfahampshire force-pushed the max/general-abstraction-updates branch from 668e38b to 5981872 Compare April 27, 2025 16:20
@mfahampshire mfahampshire requested review from durch, octol and serinko April 27, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durch durch Awaiting requested review from durch

@octol octol Awaiting requested review from octol octol is a code owner

@serinko serinko Awaiting requested review from serinko

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfahampshire