Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TaskStatusEvent trait instead of piggybacking on Error #4919

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

octol
Copy link
Contributor

@octol octol commented Sep 23, 2024

  • Create trait for status events
  • Rename trait
  • Remove requiring error trait

This change is Reviewable

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 8:07am
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 8:07am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 8:07am

@octol octol force-pushed the jon/create-task-event-trait branch from e8ee22f to 7f434b2 Compare November 7, 2024 22:55
@octol octol marked this pull request as ready for review November 7, 2024 22:55
@octol octol requested a review from neacsu November 7, 2024 22:56
@octol octol added this to the Crunch milestone Nov 7, 2024
@octol octol merged commit 0bb287a into develop Nov 8, 2024
21 checks passed
@octol octol deleted the jon/create-task-event-trait branch November 8, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants