-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add container build here #2
Conversation
@eiriksm We have a very outdated version of nymediaas/chrome-headless on docker hub (>3y old, it can walk and talk at this point), and AFAIK this is manually pushed. This wants to make the process automated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to move to not using this base image though. I have done some efforts from time to time to check if we can change this, but it's going to break for sure.
That being said, I guess this just pushes it to ghcr so that would be fine. So no breakage in sight if we just start to do that
Care to expand a bit on this? |
My reason was: It seems to be unmaintained and out of date. BUT I was going to the docker hub page to get some verification of that claim, and it's actually not at all 🤔 I guess it was at some point but then resurrected? |
Yeah, I looked at the github and it looked relatively alive. 😄 Well, for now I mostly needed to test it with for this PR: https://github.com/nymedia/akademika_d8/pull/4433 |
What