Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add container build here #2

Merged
merged 9 commits into from
Dec 7, 2023
Merged

feat: add container build here #2

merged 9 commits into from
Dec 7, 2023

Conversation

esolitos
Copy link
Contributor

@esolitos esolitos commented Dec 6, 2023

What

@esolitos esolitos requested a review from eiriksm December 7, 2023 07:58
@esolitos
Copy link
Contributor Author

esolitos commented Dec 7, 2023

@eiriksm We have a very outdated version of nymediaas/chrome-headless on docker hub (>3y old, it can walk and talk at this point), and AFAIK this is manually pushed.

This wants to make the process automated.

Copy link
Member

@eiriksm eiriksm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to move to not using this base image though. I have done some efforts from time to time to check if we can change this, but it's going to break for sure.

That being said, I guess this just pushes it to ghcr so that would be fine. So no breakage in sight if we just start to do that

@esolitos esolitos merged commit 7f1d204 into main Dec 7, 2023
4 checks passed
@esolitos
Copy link
Contributor Author

esolitos commented Dec 7, 2023

I would like to move to not using this base image though.

Care to expand a bit on this?

@esolitos esolitos deleted the ghcrio branch December 7, 2023 08:08
@eiriksm
Copy link
Member

eiriksm commented Dec 7, 2023

My reason was: It seems to be unmaintained and out of date.

BUT

I was going to the docker hub page to get some verification of that claim, and it's actually not at all 🤔 I guess it was at some point but then resurrected?

@esolitos
Copy link
Contributor Author

esolitos commented Dec 7, 2023

Yeah, I looked at the github and it looked relatively alive. 😄
But then again, they say the latest version is 100, while chrome is now at 120.. so.. Yeah, not the best. Perhaps I can replace the base image with the actual installation steps, they're very basic anyway.

Well, for now I mostly needed to test it with for this PR: https://github.com/nymedia/akademika_d8/pull/4433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store images in the ghcr.io container registry
2 participants