Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file_path from build JSON request #512

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Remove file_path from build JSON request #512

merged 3 commits into from
Mar 3, 2025

Conversation

kraju3
Copy link
Contributor

@kraju3 kraju3 commented Feb 3, 2025

Description

Remove file_path from the attachments object to prevent invalid requests in the future via our Send API.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@kraju3 kraju3 linked an issue Feb 3, 2025 that may be closed by this pull request
@matiassalles99
Copy link

Kiran rocks! 🚀

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (6c7d363) to head (232775b).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   98.83%   98.85%   +0.01%     
==========================================
  Files          29       29              
  Lines         774      783       +9     
==========================================
+ Hits          765      774       +9     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kraju3
Copy link
Contributor Author

kraju3 commented Feb 13, 2025

@AaronDDM are we good to close this one?

@AaronDDM AaronDDM merged commit fc9e262 into main Mar 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file_path parameter is deprecated and requests will start erroring
3 participants