Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added attributes organizer_email and organizer_name to the Event Object #409

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

kraju3
Copy link
Contributor

@kraju3 kraju3 commented Mar 13, 2023

Description

  • Ruby SDK Event object was missing the fields organizer_name and organizer_email. The workaround previously was to parse the owner field of the Event object.

https://nylas.atlassian.net/browse/CUST-1575

#406

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@kraju3 kraju3 requested a review from mrashed-dev March 13, 2023 23:32
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #409 (1d64cdc) into main (ef90d46) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         128      128           
  Lines        4717     4721    +4     
=======================================
+ Hits         4615     4619    +4     
  Misses        102      102           
Impacted Files Coverage Δ
lib/nylas/event.rb 100.00% <100.00%> (ø)
spec/nylas/event_spec.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kraju3 kraju3 linked an issue Mar 13, 2023 that may be closed by this pull request
@mrashed-dev mrashed-dev merged commit 5bf0561 into main Mar 14, 2023
@mrashed-dev mrashed-dev deleted the CUST-1575 branch March 14, 2023 13:31
@tvongaza tvongaza mentioned this pull request Mar 18, 2023
mrashed-dev pushed a commit that referenced this pull request Apr 4, 2023
The API returns updated_at for events, but it is not included in the ruby client event model. This PR adds the updated_at attribute and related spec. This was referenced in #407 which was closed by #409, but it didn't actually add the updated_at attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event (and maybe other objects) missing 'updated_at' attribute.
2 participants